add python 3.8.0rc1, refactor #5
Conversation
| else | ||
| py_bin=/usr/bin/python$py_ver | ||
| fi | ||
| if [ ! -e py_bin ]; then | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
i am not sure what happens if this script exits, since it is a wrapper
|
I verified that this image works with the numpy-wheels build locally. Are there any further checks I can do for validity? |
|
Needs rebase. |
|
Sorry - yes - I merged this, with another commit on top - thanks. I think the merge generated the 64-bit container, and I pushed up the 32-bit container manually - so the containers should be good to go now. |
|
Still not working Is it getting the image from the right place? How to check if the images are correctly updated? |
|
It's updated, but I forgot to update the script that activates Python, to take into account versions greater than 3.7. Should be done in 20 minutes or so. |
|
Oops - no - sorry - I need to fix my fix. Will post here when done / uploaded. |
|
Somehow 6dc8eaf didn't make it into the merge |
|
Yes, sorry, I'm not sure what happened there. I think I've caught up with you now though. |
|
I did manual uploads. Travis build should find them now. |
|
Yay, it worked, both 64 and 32 bits. I'll make a push to numpy-wheels master so we can get some testing. What do we need for Mac and Windows? |
Update the Dockerfile so that hopefully future python versions will not require a complete rebuild (i.e. the move from python
3.8.0rc1to3.8.0). Also add 3.8.0rc1 to the image